This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test($resource): enhance test-case to verify correct behaviour #9628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
referenced
this pull request
Oct 15, 2014
BREAKING CHANGE: If you expected `$resource` to strip these types of properties before, you will have to manually do this yourself now.
| expect(cc.$promise).toBeDefined(); | ||
| expect(cc.$resolved).toBe(true); | ||
| expect(cc.$myProp).toBe('still here'); |
There was a problem hiding this comment.
this assertion is kind of meaningless since the item was defined just above
gkalpak
force-pushed
the
$resource-enhance-toJson-test
branch
from
f3d0ccd to
1a73a7b
Compare
Previously, the test-case verified that calling `toJson()`, would remove the `$promise` and `$resolved`, but not that other `$`-prefixed properties would not be removed.
gkalpak
force-pushed
the
$resource-enhance-toJson-test
branch
from
1a73a7b to
fff74ab
Compare
|
thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the test-case verified that calling
toJson(), would remove the$promiseand$resolved, but not that other$-prefixed properties would not be removed.