Anchor scroll offset

[petebacondarwin]

No description provided.

[atticoos]

What happens here if there are multiple waypoints on the page that may use desire different offsets?

Maybe this is a non issue, but may want to update the provider doc w/ a note that only one offset element may be defined on a page at once.

[petebacondarwin]

@ajwhite - if I understand you correctly, what you are asking, is what happens if the offset changes depending upon how far down the page you have scrolled, yes? I think this is supported if you always use the same DOM element to contain whatever is being displayed at the top of the page then pass that to the $anchorScroll service. If you want something more sophisticated you are free to provide a function to the service that can do whatever computation it requires to work out what the current offset is.

[atticoos]

I'm referring to scroll-y-offset-element directive -- isn't this what determines the offset of the scroll?
Might be good to include that this can only be used once per page, as multiple scroll-y-offset-element attributes would conflict the provider's offset. Might want to make it configurable, like
scroll-y-offset-element="hashName" so that it can be applicable to one anchor, or all.

[petebacondarwin]

@gkalpak - by the way, I didn't mean to lose your authorship on the commits and I will put that back before we merge

[petebacondarwin]

@ajwhite - I see what you mean but that directive is not part of the public API of angular.js. It is just a directive that we wrote for the specific purposes of the angular docs app.

[atticoos]

Oh! I see what you mean now too. You're just adding that offset option to the provider.
I redact my comment! Nice work, 👍

[petebacondarwin]

No problem. If only it worked on Firefox and IE: https://travis-ci.org/angular/angular.js/jobs/37292590#L3125

[tbosch]

Can we close this in favor of #9517