Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(npm): publish artifacts to npm #9376

Merged
merged 1 commit into from
Oct 6, 2014

Conversation

btford
Copy link
Contributor

@btford btford commented Oct 1, 2014

Note that there are still a few pending tasks before this can land, namely getting permissions for all of the package names on npm:

If you own one of these packages, you can help by adding user "angularcore" to the package

unclaimed:

  • angular-aria
  • angular-i18n
  • angular-loader
  • angular-scenario
  • angular-touch
  • angular-messages

I also still need to add package.json for each bower-angular-* repo (since that's how we'll be publishing these artifacts). done!

Closes #2877

@Zizzamia
Copy link
Contributor

Zizzamia commented Oct 2, 2014

I'm happy to make the name "angular-mocks" for the Angular Team to use.

@btford
Copy link
Contributor Author

btford commented Oct 2, 2014

@Zizzamia thanks! Can you give npm user "angularcore" the permissions?

@btford btford added this to the 1.3.0-rc.5 milestone Oct 2, 2014
@alexgorbatchev
Copy link

👍 thanks @Zizzamia

@roylines
Copy link

roylines commented Oct 2, 2014

I am happy to hand over angular-resource. Try and sort it tomorrow.

@mljsimone
Copy link

angular-route now belongs to angularcore. Thanks guys!

@lgalfaso
Copy link
Contributor

lgalfaso commented Oct 2, 2014

angular-animate belongs to @PitBeast

@btford
Copy link
Contributor Author

btford commented Oct 2, 2014

@lgalfaso good call.

@dylang
Copy link

dylang commented Oct 2, 2014

@mljsimone Did we lose older versions of angular-route in this transition? We were using 1.2.12 but it doesn't seem to be available anymore.

Edit: It seems more likely that we had this on our private npm server and it was overwritten when the official package was published. Our issue, not yours. Sorry for any confusion!

@Zizzamia
Copy link
Contributor

Zizzamia commented Oct 3, 2014

Done! :)

@roylines
Copy link

roylines commented Oct 3, 2014

I've added angularcore as owner of angular-resource. I've left myself as an owner for the time being (in case of any issues). Feel free to boot me out when you are happy you have necessary ownership rights.

@PitBeast
Copy link

PitBeast commented Oct 4, 2014

I've provide access to angular-sanitize and angular-animate.

@txbm
Copy link

txbm commented Oct 5, 2014

I've just transferred ownership of the angular-cookies namespace to angularcore

@btford
Copy link
Contributor Author

btford commented Oct 5, 2014

Woo! Should basically be good to go. 💃

@btford btford force-pushed the chore-npm-publish branch from 8fbe979 to a21d49c Compare October 6, 2014 18:39
@btford btford merged commit a21d49c into angular:master Oct 6, 2014
@btford
Copy link
Contributor Author

btford commented Oct 6, 2014

Landed as a21d49c.

@alexgorbatchev
Copy link

Btw, I want to point out the obvious here - it's super cool that everyone gave up their project names for the greater good of the ecosystem. Thanks! 👍

@leon
Copy link

leon commented Nov 17, 2014

@btford Would it be possible to also publish the latest 1.2 releases to npm?

@btford
Copy link
Contributor Author

btford commented Nov 17, 2014

We'll publish the next 1.2 release to npm. We can't publish past releases
because some of the packages on npm already have releases published with
those versions.
On Mon Nov 17 2014 at 12:50:23 AM Leon Radley notifications@github.com
wrote:

@btford https://github.com/btford Would it be possible to also publish
the latest 1.2 releases to npm?


Reply to this email directly or view it on GitHub
#9376 (comment).

@mgol
Copy link
Member

mgol commented Nov 17, 2014

TBH I'm not sure if publishing Angular 1.2 to npm is a good idea. The npm angular package is one provided as a CommonJS module so such a publication would break people that put "angular": "~1.2.0" in their package.json. It's an universally accepted practice in npm to depend on patch updates not introducing any breaking changes, not to mention such a huge package swap.

I don't think there's a safe way to publish Angular 1.2 to npm, it should be left as it is IMO.

@bclinkinbeard
Copy link
Contributor

+1 on @mzgol's comment

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please publish AngularJS as an NPM module