Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(*): fix dangling links #9367

Closed
wants to merge 1 commit into from
Closed

docs(*): fix dangling links #9367

wants to merge 1 commit into from

Conversation

lgalfaso
Copy link
Contributor

@lgalfaso lgalfaso commented Oct 1, 2014

Fix many dangling links

@petebacondarwin
Copy link
Contributor

Thanks @lgalfaso - these and the checkAnchors processor you wrote are going to improve the docs a lot.

A number of these fixes are not optimal though. For instance most API entities, such as a service can be referenced in a {@link ... } tag directly or with minimal qualification. So we don't need to resort to real URLs in these cases.

@lgalfaso
Copy link
Contributor Author

lgalfaso commented Oct 6, 2014

let me look into this later today

@petebacondarwin
Copy link
Contributor

Also I have just refactored parts of and merged your angular/dgeni-packages#78
Do take a look. Great stuff by the way. Thanks again

Fix many dangling links
@lgalfaso
Copy link
Contributor Author

lgalfaso commented Oct 7, 2014

There are a few pending things outside of this PR

Once dgeni is updated here, there is a need to update the configuration

@jeffbcross jeffbcross force-pushed the master branch 2 times, most recently from abdaab7 to 30996f8 Compare October 8, 2014 19:47
@petebacondarwin
Copy link
Contributor

@lgalfaso - are these pending things basically just docs things that need fixing or issues with this PR?

@lgalfaso
Copy link
Contributor Author

lgalfaso commented Oct 9, 2014

@petebacondarwin all the pending things are out of the scope of this PR

@petebacondarwin
Copy link
Contributor

Shall we create new issues for them? (Or did you do that already?)

@lgalfaso
Copy link
Contributor Author

lgalfaso commented Oct 9, 2014

I just saw that you already fixed some of the issues in your refactor at dgeni-packages. The remaining things are

The later point, will open a defect to remove it or for someone to write it

@tbosch tbosch assigned tbosch and unassigned tbosch Oct 9, 2014
@tbosch tbosch added this to the Backlog milestone Oct 9, 2014
@tbosch
Copy link
Contributor

tbosch commented Oct 9, 2014

Closing this based on the discussion above.

@tbosch tbosch closed this Oct 9, 2014
@petebacondarwin
Copy link
Contributor

No! The discussion is about things outside of the scope of this PR. This PR still needs to be merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants