This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($http): add missing shortcut methods and missing docs #9321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was some inconsistency in version 1.2.25 regarding the definition and documentation of shortcut methods in `ng.$http` and `ngMock[E2E].$httpBackend`. Some methods didn't exist (although documented as existing), whereas some methods did exist, but wheren't documented. This commit fixes the above errors and adds tests to verify the existence of all shortcut methods. More specificcally, the following issues were addressed: `ng.$http`: Add the missing `patch()` shortcut method and related docs. `ng.$http` spec: Add test to verify the existence and functionality of the `patch()` shortcut method. `ngMock[E2E].$httpBackend`: Add docs for the (existing) `whenPATCH()` shortcut method, add the missing `expectHEAD()`/`whenHEAD()` shortcut methods, fix grammatical errors. `ngMock[E2E].$httpBackend` spec: Add test to verify the existence of shortcut methods for all HTTP verbs. Closes angular#9180
| @@ -1186,7 +1186,7 @@ function createHttpBackendMock($rootScope, $delegate, $browser) { | |||
| * data string and returns true if the data is as expected. | |||
| * @param {(Object|function(Object))=} headers HTTP headers or function that receives http header | |||
| * object and returns true if the headers match the current definition. | |||
| * @returns {requestHandler} Returns an object with `respond` method that controls how a matched | |||
| * @returns {requestHandler} Returns an object with a `respond` method that controlss how a matched | |||
|
I would make this just a docs update and drop the "feature" change |
petebacondarwin
pushed a commit
that referenced
this pull request
Oct 9, 2014
There was some inconsistency in version 1.2.25 regarding the definition and documentation of shortcut methods in `ng.$http` and `ngMock[E2E].$httpBackend`. Some methods didn't exist (although documented as existing), whereas some methods did exist, but wheren't documented. This commit fixes the above errors and adds tests to verify the existence of all shortcut methods. More specificcally, the following issues were addressed: `ng.$http`: Add the missing `patch()` shortcut method and related docs. `ng.$http` spec: Add test to verify the existence and functionality of the `patch()` shortcut method. `ngMock[E2E].$httpBackend`: Add docs for the (existing) `whenPATCH()` shortcut method, add the missing `expectHEAD()`/`whenHEAD()` shortcut methods, fix grammatical errors. `ngMock[E2E].$httpBackend` spec: Add test to verify the existence of shortcut methods for all HTTP verbs. Closes #9180 Closes #9321
|
Landed as ec4fe1b |
gkalpak
deleted the
add-missing-shortcut-methods-and-docs-to-$http-v1.2.25
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some inconsistency in version 1.2.25 regarding the definition and documentation of shortcut methods in
ng.$httpandngMock[E2E].$httpBackend. Some methods didn't exist (although documented as existing), whereas some methods did exist, but wheren't documented.This commit fixes the above errors and adds tests to verify the existence of all shortcut methods.
More specificcally, the following issues were addressed:
ng.$http: Add the missingpatch()shortcut method and related docs.ng.$httpspec: Add test to verify the existence and functionality of thepatch()shortcut method.ngMock[E2E].$httpBackend: Add docs for the (existing)whenPATCH()shortcut method, add the missingexpectHEAD()/whenHEAD()shortcut methods, fix grammatical errors.ngMock[E2E].$httpBackendspec: Add test to verify the existence of shortcut methods for all HTTP verbs.Closes #9180