Update directive.ngdoc #9311
Update directive.ngdoc #9311
Conversation
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I think the existing text is clearer and more accurate. What was confusing to you about the way it is currently written? |
|
Because I guess it's more clear to say that this binding types aren't only for ngBind, but for all directives. When I saw this text for the first time, I guessed that it was just for ngBind. Don't you think? |
|
I think it's confusing anyway (they are not elements that match
|
|
Better! +1 |
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
|
I like @gkalpak's version of the opening sentence as well --- I would like to see that change applied. Additionally, @VictorQueiroz we are missing a CLA signature, could you plesae sign the CLA with the email address from https://github.com/angular/angular.js/pull/9311.patch ? Please do that and then ping me. Thanks! |
|
Done! :) |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
I merged in @gkalpak's version and reordered the example files so that the index appears first, which seems to be the obvious thing to do. |
No description provided.