docs(ngShowHide): improve consistency in ngShowHide documentation #9081
Conversation
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
There are a few instances of class names used in the document that didn't get backtick'd --- do you want to add those too? (the animation subheading in particular) |
add backticks around directive names to improve documentation consistency
|
I added some more backticks and I submitted another CLA with an updated email. |
|
Don't worry about the CLA signature (it's not necessary for docs), however it needs to be signed with nokami.hybrids@... for this patch (because that's the address this was authored with). |
|
Oh ok, do I update the commit with my email then? How do I sign it? |
|
you just sign through the form (instructions in CONTRIBUTING.md, linked in mp's first message) --- it's just that for mp to recognize that you've signed it, you need to sign with the email address that you authored your patch with (which frequently confuses people, myself included) |
|
The patch doesn't apply cleanly for v1.2.x, if you want to sort out the conflicts and submit a second pull request there we could merge it there too. Thanks for the patch. |
…ames add backticks around directive names to improve documentation consistency, as it's used in some parts of the docs already. Closes angular#9081
add backticks around directive names to improve documentation consistency