Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(navigation): side navigation footer overlap problem fix #8728

Closed
wants to merge 1 commit into from
Closed

docs(navigation): side navigation footer overlap problem fix #8728

wants to merge 1 commit into from

Conversation

sercaneraslan
Copy link
Contributor

screen shot 2014-08-22 at 18 09 10

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@sercaneraslan
Copy link
Contributor Author

I signed CLA, what do I do now?
Thank you.

@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@sercaneraslan sercaneraslan changed the title Side navigation footer overlap problem fixed docs(navigation): side navigation footer overlap problem fix Aug 22, 2014
@jeffbcross jeffbcross self-assigned this Sep 3, 2014
@jeffbcross jeffbcross added this to the Backlog milestone Sep 3, 2014
@jeffbcross
Copy link
Contributor

Hi @sercaneraslan can you provide some more information?

  • What browser/platform are you using?
  • What was the root cause of this spacing issue?
  • How did you come up with 136 pixels?

And please update the commit message per our contribution guidelines

@jeffbcross jeffbcross removed their assignment Sep 3, 2014
@sercaneraslan
Copy link
Contributor Author

I'm closed this issue because I made wrong fix. The new issue is: #8923 (I added more detail information)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants