Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

feat(ngMock): allow override of when/expect definitions #8352

Closed
wants to merge 1 commit into from
Closed

feat(ngMock): allow override of when/expect definitions #8352

wants to merge 1 commit into from

Conversation

shahata
Copy link
Contributor

@shahata shahata commented Jul 26, 2014

Closes #5766

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#8352)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@shahata shahata added cla: yes and removed cla: no labels Jul 26, 2014
@petebacondarwin
Copy link
Contributor

I like this option. It is clean, makes very little change to the codebase and is easy to understand in tests.

@petebacondarwin
Copy link
Contributor

Adding to next milestone and happy to merge if @IgorMinar can LGTM it.

@IgorMinar
Copy link
Contributor

otherwise lgtm

@shahata
Copy link
Contributor Author

shahata commented Aug 1, 2014

Cool. I added the missing example.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.