Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(orderBy): changes orderBy to use case sensitive comparison to break ... #8112

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/ng/filter/orderBy.js
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,12 @@ function orderByFilter($parse){
var t2 = typeof v2;
if (t1 == t2) {
if (t1 == "string") {
v1 = v1.toLowerCase();
v2 = v2.toLowerCase();
var v1Lower = v1.toLowerCase();
var v2Lower = v2.toLowerCase();
if (v1Lower !== v2Lower) {
v1 = v1Lower;
v2 = v2Lower;
}
}
if (v1 === v2) return 0;
return v1 < v2 ? -1 : 1;
Expand Down
6 changes: 6 additions & 0 deletions test/ng/filter/orderBySpec.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,10 @@ describe('Filter: orderBy', function() {
return orderBy([{"Tip %": .15}, {"Tip %": .25}, {"Tip %": .40}], '"Tip %\'');
}).toThrow();
});

it('should sort strings in a case sensitive way', function() {
var array = [{name:"Bb"}, {name:"BB"}, {name:"bb"}, {name:'Aa'}, {name:'aa'}, {name:'AA'}];
expect(orderBy(array, 'name', true)).toEqualData([{name:"bb"}, {name:"Bb"}, {name:"BB"}, {name:'aa'}, {name:'Aa'}, {name:'AA'}]);
expect(orderBy(array, 'name', true)).toEqualData(orderBy(array, 'name', false).reverse());
});
});