fix($sce): fix adjustMatcher to replace multiple '*' and '**' #7897
Conversation
adjustMatcher was only replacing the first '*' and '**' found on the whitelisted and blacklisted urls.
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
I signed the CLA again (I did already in the past with the same email address) |
|
CLA signature verified! Thank you! Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes). |
|
More context on here. It doesn't mention that you can use wildcards only once. |
petebacondarwin
force-pushed
the
master
branch
from
02dc2aa to
fd2d6c0
Compare
jeffbcross
force-pushed
the
master
branch
2 times, most recently
from
cad9560 to
f294244
Compare
jeffbcross
force-pushed
the
master
branch
4 times, most recently
from
e8dc429 to
e83fab9
Compare
petebacondarwin
force-pushed
the
master
branch
from
4dd5a20 to
998c61c
Compare
|
I ran into this issue again. The workaround is straighforward but merging this would be nice given that it's such a small fix. |
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes ##7897
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes ##7897
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes #angular#7897
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes #angular#7897
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes #angular#7897
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes #angular#7897
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes #angular#7897
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes ##7897
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes ##7897
`adjustMatcher` was only replacing the first occurrences of '*' and '**' that were found in whitelisted and blacklisted url strings. Closes #angular#7897
On
$sceDelegateProvidetheadjustMatcherfunction was only replacing the first*and**found on the whitelisted and blacklisted urls. This caused $sceDelegate policy problems for example when trying to match*://*.example.com/**againsthttps://www.example.com/path.