This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(currencyFilter): Remove hardcoded fractionSize in currency #7539
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Request Type: bug
How to reproduce: _
Expected behaviour:
The string outputted follows the pattern rules set in $locale
Actual behaviour:
The minFrac and maxFrac properties are ignored
Component(s): misc core
Impact: small
Complexity: small
This issue is related to:
Detailed Description:
The hardcoded fractionSize in the
currencyFilter
makes the minFrac and maxFrac options in $locale redundant.The default minFrac and maxFrac options in $locale are functionally equivalent and removing the hardcoded value would allow the behaviour of the currencyFilter to be customisable.
Other Comments:
The motivation behind this change is to make i18n of currencies slightly easier.
Currencies such as the Yen typically are rendered with no decimal places, and the Dinar is usually rendered with 3 decimal places. Please refer to http://en.wikipedia.org/wiki/ISO_4217#cite_note-ReferenceA-6 for a full list of currencies and their decimal places.