docs($location): confusing terminology (observers) #7497
Conversation
The term 'observer' isn't used anywhere else throughout the documentation to refer to the scope changes handler. Also I don't see a need in using $ here.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
| When you change the `$location` inside the `$digest` phase everything is ok; `$location` will | ||
| propagate this change into browser and will notify all the $watchers / $observers. | ||
| propagate this change into browser and will notify all the watchers. |
There was a problem hiding this comment.
Maybe it would be better to just link to the Scope / Attributes methods instead, to mitigate the confusion? I think links are good.
There was a problem hiding this comment.
Okay, this has been fixed a bit differently in d8c5586 --- but the PR is appreciated, please help us make the docs even clearer, there is a lot more of that left to do
There was a problem hiding this comment.
Why do we need to mention the $observe method here in the first place? Watchers are used for a lot of different things. And $observe is just one of them. If we are talking about the scope life-cycle and watchers in general, why mention this specific use case? That was my point.
Also, you've kept the dollar signs here: 'all the $watchers / $observers'. What for? For those not in the know, it seems that 'watchers' and '$watchers' might be different things. An example of such $confusion: http://ng.malsup.com/#!/scope-vs-$scope
… with links Add links to API docs for Scope#$watch and Attributes#$observe in $location in order to clarify the meaning of that terminology. Closes #7497
… with links Add links to API docs for Scope#$watch and Attributes#$observe in $location in order to clarify the meaning of that terminology. Closes angular#7497
The term 'observer' isn't used anywhere else throughout the documentation to refer to scope changes handlers. Also I don't see a need in using $ here.