This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Improve intelligibility of module.factory note #7022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems as though this sentence wasn't written the way it was originally planned. I did my best to approximate the intent of the original author.
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
jonathansampson
changed the title
caitp
pushed a commit
that referenced
this pull request
Apr 7, 2014
…onventions It seems as though this sentence wasn't written the way it was originally planned. I did my best to approximate the intent of the original author. Closes #7022
|
Thanks very much =) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: improving intelligibility of module.factory note
In its current form, the
module.factorynote regarding naming conventions reads contrary to what I believe the original author intended. Modify the text to approximate the intent of the original author.No breaking changes.