Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Made the sentence more clear. #6998

Closed
wants to merge 1 commit into from
Closed

Conversation

trusktr
Copy link
Contributor

@trusktr trusktr commented Apr 5, 2014

It was hard to understand.

It was hard to understand.
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6998)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@petebacondarwin petebacondarwin self-assigned this Apr 5, 2014
@trusktr trusktr added cla: yes and removed cla: no labels Apr 5, 2014
* Use the inline bracket notation which wraps the function to be injected into an array of strings
(representing the dependency names) followed by the function to be injected:
* Use the inline bracket notation to wrap the required dependencies into an array of strings
(the dependency names) followed by the function that gets injected with those dependencies:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would you feel about something like

Use the inline bracket notation to create an array containing the symbol names to inject (as strings) into the function, in the order they are passed in as arguments, and with the final parameter in the array being the function itself.

Maybe that's a bit wordy, but I think the subject is a bit hard to describe in a 2 line blob.

@trusktr
Copy link
Contributor Author

trusktr commented Apr 6, 2014

That's much clearer. I like it. I think removing the "and" and changing "parameter" to "element" and would make it golden.

Use the inline bracket notation to create an array containing the symbol names to inject (as strings) into the function, in the order they are passed in as arguments, with the final element in the array being the function itself.

@trusktr trusktr closed this Apr 6, 2014
@trusktr trusktr reopened this Apr 6, 2014
@trusktr
Copy link
Contributor Author

trusktr commented Apr 6, 2014

Oops, I hit the close button on accident. xD

@petebacondarwin
Copy link
Contributor

Thanks @trusktr - I decided we needed make the whole section a bit clearer so I added to your commit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants