Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Fix explanation of script tag change #6996

Closed
wants to merge 1 commit into from
Closed

Fix explanation of script tag change #6996

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs/content/tutorial/step_07.ngdoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,10 +129,13 @@ __`app/index.html`:__
</html>
```

We have added to extra `<script>` tags in our index file to load up extra JavaScript files into our
We have added an extra `<script>` tag to our index file to load up an extra JavaScript file into our
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be:

We have added two extra <script> tags in our index file to load up extra JavaScript files into our
application:

  • angular-route.js : defines the ngRoute module.
  • controllers.js : defines a new phonecatControllers module.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it could be that too, but there is really one script tag added compared to the previous step... but that'd be better than "to" too. I can change if you want.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, there are two script tags added, however controllers.js is present in step 6. The one which seems to be added is app.js.

I think maybe the tutorial app is broken, because that doesn't seem right. @petebacondarwin tutorial guru, does it actually work? I don't see how the injector gets created properly at all until step 7, that seems broken.

application:

- `angular-route.js` : defines the `ngRoute` module.

This is in addition to the previously specified `<script>` tag:

- `controllers.js` : defines a new `phonecatControllers` module.

Note that we removed most of the code in the `index.html` template and replaced it with a single
Expand Down Expand Up @@ -330,4 +333,4 @@ step 8} to implement the phone details view.
<ul doc-tutorial-nav="7"></ul>


[bower]: http://bower.io
[bower]: http://bower.io