Fix typo in Wikipedia link to minification #6377
Conversation
|
Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
Hey, unfortunately this doesn't fix the link, and the current dgeni docs have the link broken too. This seems like something Pete would be good at fixing if he weren't probably sleeping by now. This is going to need a fix in the docs generator, though |
|
Sorry about the time taken. Should I go ahead and close the request? |
|
Nah don't worry about it, but we should figure out a fix for the current docs! |
|
I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS. Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match. If you signed the CLA as a corporation, please let us know the company's name. Thanks a bunch! PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR. |
|
You know what, this isn't a bug with dgeni, it's a bug with marked... They use a simple regexp to parse urls. It might be possible to fix it, but that kinda sucks. |
|
I'm not sure this is going to be fixable quickly, maybe we should use a url shortener for the time being so that this works for people? |
|
Given that the original issue has been open for a year, I don't anticipate a fix any time soon. Using a URL shortener seems like a good compromise for the time being, especially since I'm not heavily invested in this issue. |
| @@ -109,7 +109,7 @@ properties are considered private, and should not be accessed or modified. | |||
| ### A Note on Minification | |||
|
|
|||
| Since Angular infers the controller's dependencies from the names of arguments to the controller's | |||
| constructor function, if you were to [minify](http://en.wikipedia.org/wiki/Minification_(programming)) the JavaScript code for `PhoneListCtrl` controller, all of its function arguments would be | |||
| constructor function, if you were to [minify](http://en.wikipedia.org/wiki/Minification_(programming\)) the JavaScript code for `PhoneListCtrl` controller, all of its function arguments would be | |||
There was a problem hiding this comment.
I was going to just amend the commit and check this in, but unfortunately stuff is broken right now so I don't really want to check it in just yet. But just to make a note of the change, I've replaced http://en.wikipedia.org/wiki/Minification_(programming) with http://goo.gl/SAnnsm as a temporary measure to get around the marked brokenness.
If you want to repeat this change so this can be checked in, please also make a note of the original URL in the commit message, just in case anything happens to the shortened link, or if the marked bug gets fixed.
… URL marked has an existing bug where links ending with a ')' will not be parsed correctly. The workaround is to use a shortened URL. The original URL that is being replaced by this commit is 'http://en.wikipedia.org/wiki/Minification_(programming)'. Closes angular#6377
… URL marked has an existing bug where links ending with a ')' will not be parsed correctly. The workaround is to use a shortened URL. The original URL that is being replaced by this commit is 'http://en.wikipedia.org/wiki/Minification_(programming)'. Closes angular#6377
marked has an existing bug where links ending with a ')' will not be parsed correctly. The workaround is to use a shortened URL. The original URL that is being replaced by this commit is http://en.wikipedia.org/wiki/Minification_(programming) . Closes angular#6377
|
Sorry for all the pushes. The last one should be good to go now. |
|
Merged, thanks |
Right now the "minify" link in this document yields the URL "http://en.wikipedia.org/wiki/Minification_(programming". Escaping the first closing parenthesis should fix this.