Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(doc-gen): add a jquery deploy environment, and give examples one i... #6361

Closed
wants to merge 1 commit into from

Conversation

juliemr
Copy link
Member

@juliemr juliemr commented Feb 20, 2014

...ndex per environment

Adds a jQuery environment, and adds a processor to the docs.angularjs.org package
which runs after example index files have been generated. This processor copies
the index file once for each deployment environment, adding custom shared scripts
described in that env.

This does not yet handle changing the target of the iframe, so those all point
to the default no matter the version of docs being accessed.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6361)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@juliemr
Copy link
Member Author

juliemr commented Feb 20, 2014

Please note that this is pending angular/dgeni-packages#3, a fix for the example processor.

…e index per environment

Adds a jQuery environment, and updates dgeni-packages dependency to add a processor
to the docs.angularjs.org package which runs after example index files have been generated.
This processor copies the index file once for each deployment environment, adding custom
shared scripts described in that env.

This does not yet handle changing the target of the iframe, so those all point
to the default no matter the version of docs being accessed.
@juliemr
Copy link
Member Author

juliemr commented Feb 21, 2014

The new dgeni-packages version is in - this is ready to go!

EDIT: not ready at all - something weird is going on with the index.html generation.

EDIT2: Bug addressed in angular/dgeni-packages#5

@petebacondarwin
Copy link
Contributor

Regarding handling retargeting the iframe. This is probably best done by providing a value for the current deployment to angular in the index-xxx.html. The runnableExample directive could then modify the iframe src attribute accordingly.
I have a dgeni feature in the works for handling inline tags in a more flexible manner. Once that is in, we can move the bit of code that injects the example HTML code into a template and in there we can make the necessary changes to the iframe.

config.set('processing.examples.commonFiles', {
scripts: [ '../../../angular.js' ],
stylesheets: []
});
config.set('processing.examples.dependencyPath', '../../..');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line needs to be removed as the dependencyPaths are now inside the deployments below.

@petebacondarwin
Copy link
Contributor

Also we need to change the commit message, which is not in sync with the code now.

@juliemr juliemr closed this in 4d7e1ce Feb 21, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants