Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Update ie.ngdoc #6227

Closed
wants to merge 1 commit into from
Closed

Update ie.ngdoc #6227

wants to merge 1 commit into from

Conversation

toebu
Copy link
Contributor

@toebu toebu commented Feb 12, 2014

Browser: IE8
Component: docs
Regression: no

Text specifies "polyfill JSON.stringify for IE7 and below" conditional comment for loading the polyfill was "lte IE 8". According to https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/JSON/stringify IE8 supports JSON.stringify, so the text was correct, conditional comment was wrong.

Text specifies "polyfill JSON.stringify for IE7 and below" conditional comment for loading the polyfill was "lte IE 8".
@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6227)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@toebu
Copy link
Contributor Author

toebu commented Feb 12, 2014

Shouldn't there be a component "documentation" in the issue template?

@btford
Copy link
Contributor

btford commented Feb 12, 2014

@toebu 👍 I'll add it.

@toebu
Copy link
Contributor Author

toebu commented Feb 12, 2014

Nice!

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@toebu toebu added cla: no and removed cla: yes labels Feb 19, 2014
@mary-poppins
Copy link

CLA signature verified! Thank you!

Someone from the team will now triage your PR and it will be processed based on the determined priority (doc updates and fixes with tests are prioritized over other changes).

@toebu toebu added cla: yes and removed cla: no labels Feb 20, 2014
@caitp caitp closed this in 84ad0a0 Feb 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants