Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs: remove ngRoute.$routeParams link from ng module services example #6219

Closed
wants to merge 1 commit into from

Conversation

inetfuture
Copy link
Contributor

No description provided.

@mary-poppins
Copy link

Thanks for the PR! Please check the items below to help us merge this faster. See the contributing docs for more information.

  • Uses the issue template (#6219)

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@caitp
Copy link
Contributor

caitp commented Feb 12, 2014

@inetfuture is there any particular reason you want to remove this?

@caitp caitp added this to the Backlog milestone Feb 12, 2014
@inetfuture
Copy link
Contributor Author

I think it's in the wrong place, it belongs to ngRoute module instead of ng module, right?

@caitp
Copy link
Contributor

caitp commented Feb 12, 2014

The ngRoute module is a commonly used module, and the api section of the site isn't specific to the ng module, so I'm curious if you feel it's confusing for users or anything.

@inetfuture
Copy link
Contributor Author

Yeah, I'm a little confused when I read it, because I remember ngRoute is a separated module, I just think the doc should be accurate. Anyway, it's not a big deal if you think it's ok.

@caitp
Copy link
Contributor

caitp commented Feb 12, 2014

I'm not sure, I'll see what I think of this tomorrow

@mary-poppins
Copy link

I'm sorry, but I wasn't able to verify your Contributor License Agreement (CLA) signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let us know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@petebacondarwin
Copy link
Contributor

I agree. There is a separate section further down for ngRoute. We should move this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants