This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix($http): add support for PATCH short method #6071
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit 46691c2 removed the short method for PATCH from $http because there were too many unknows. However, angular#5823 schedules PATCH to be re-added for the 1.3.x milestone. This change adds the short method for PATCH back to the $http library, including tests. Closes angular#5823
|
God damnit, my brain farted, and I didn't see the other PR #5894. That one includes data in the tests, which is correct according to the spec (I just manually reverted 46691c2 blindly). Closing this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit 46691c2 removed the short method for PATCH from $http because there were too many unknowns. However, #5823 schedules PATCH to be re-added for the 1.3.x milestone.
This change adds the short method for PATCH back to the $http library, including tests.
Closes #5823