This repository was archived by the owner on Apr 12, 2024. It is now read-only.
renamed animate-show-hide to sample-show-hide #5848
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This always throws me off - I think it helps to make it clear that the class name is arbitrary, and what matters is the .ng-etc classes.
|
Since I didn't put a proper explanation in the commit message, I'm just dropping this here: ng-animate adds a bunch of classes during its process, and these classes (ng-animate, -add, -active, -remove, especially where is ng-hide) often confuse people, and I think this change helps make it clearer that it's not a special class decided by angular. I've already discussed with @robwormald that similar changes might be good for other directives with animation examples which rely on $animate.addClass and $animate.removeClass |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
This always throws me off - I think it helps to make it clear that the class name is arbitrary, and what matters is the .ng-etc classes. Closes angular#5848
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
This always throws me off - I think it helps to make it clear that the class name is arbitrary, and what matters is the .ng-etc classes. Closes angular#5848
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This always throws me off - I think it helps to make it clear that the class name is arbitrary, and what matters is the .ng-etc classes.