Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fixed demo animation #5234

Closed
wants to merge 2 commits into from
Closed

fixed demo animation #5234

wants to merge 2 commits into from

Conversation

gerstnr
Copy link

@gerstnr gerstnr commented Dec 2, 2013

No description provided.

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@gerstnr
Copy link
Author

gerstnr commented Dec 3, 2013

Signed the CLA.
BR, Claudius Gerstner

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

1 similar comment
@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
@petebacondarwin @jamesdaily
docs(ngIf): remove invalid comment from CSS
46676a5 
We cannot use valid /* ... */ CSS comments in examples because they break the parsing
of the ngdoc comments.  We can't use inline // comments because these are not valid in
CSS.

We could use the //!annotate extension to the ngdoc parser but this does not seem to be
working.  It is best to simply remove this line.

Closes angular#5234
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
@petebacondarwin @jamesdaily
docs(ngIf): remove invalid comment from CSS
24748b3 
We cannot use valid /* ... */ CSS comments in examples because they break the parsing
of the ngdoc comments.  We can't use inline // comments because these are not valid in
CSS.

We could use the //!annotate extension to the ngdoc parser but this does not seem to be
working.  It is best to simply remove this line.

Closes angular#5234
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cla: no
Projects
None yet
Milestone
Docs Only
Development

Successfully merging this pull request may close these issues.
3 participants
@gerstnr @mary-poppins @IgorMinar