This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(mocks): wrap angular-mocks.js in closure #5080
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
|
I have signed the CLA in the past :) |
davemo
added a commit
to linemanjs/lineman-angular-template
that referenced
this pull request
Nov 22, 2013
- mocks, resource, route, core - mocks is a result of a custom build until angular/angular.js#5080 ships
ghost
assigned 
|
This is subtly more complex - since there are a bunch of closures inside the angular-mocks file too that might as well be stripped out if we are going to wrap the whole thing. |
|
Thanks @petebacondarwin :) |
|
@davemo - we couldn't find your CLA submission. Can you sign it again please? |
|
Sure, but the link to the CLA form doesn't seem to exist anymore from http://docs.angularjs.org/misc/contribute#CLA ? |
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
jamesdaily
pushed a commit
to jamesdaily/angular.js
that referenced
this pull request
Jan 27, 2014
JohanLorenzo
pushed a commit
to JohanLorenzo/balrog
that referenced
this pull request
Sep 9, 2016
- mocks, resource, route, core - mocks is a result of a custom build until angular/angular.js#5080 ships
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
use strict;that was at the top of this file was bleeding into other files and preventing the use of other test helpers that don't use strict mode. This was in a TODO so I figured it just needed to get committed :)