Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

typo in httpBackendSpec #4830

Closed
wants to merge 1 commit into from
Closed

typo in httpBackendSpec #4830

wants to merge 1 commit into from

Conversation

bwiklund
Copy link
Contributor

@bwiklund bwiklund commented Nov 8, 2013

While browsing through the tests I found what appears to be a typo. The tests pass with and without this spy, so this is possibly something that is no longer used?

@petebacondarwin
Copy link
Contributor

The name of a spy (i.e. the string passed to the createSpy function) is purely for displaying a nice error message in the tests. So as you say changing this doesn't make any difference to the result of the tests.
The actual spy itself, on the other hand, is crucial to the tests. You can see this by commenting out the fake function body:

fakeDocument.$$scripts.push(script);

and then running the tests.

@bwiklund
Copy link
Contributor Author

Ah, makes sense. I should probably start naming my own spies...

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants