Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix(ngdocs): add ids to headers in tests #4796

Closed
wants to merge 1 commit into from

Conversation

mkolodny
Copy link
Contributor

@mkolodny mkolodny commented Nov 5, 2013

Doc.markdown (in /docs/src/ngdoc.js) gives headers ids, yet headers don't have ids in the specs.
That's causing the tests "ngdoc markdown should replace text between two [pre] tags", and "ngdoc TAG @description should support multiple pre blocks" to fail when building the documentation.
This change adds ids to headers in the specs to match the behavior of Doc.markdown.

@petebacondarwin
Copy link
Contributor

Reverting to the previous version of marked (0.2.9) has removed the need for this change. Moving this to the post-1.2 milestone to be revisited when we decide to upgrade marked.

@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@Narretz
Copy link
Contributor

Narretz commented Jul 16, 2014

ngdocs is no longer part of the doc system, closing

@Narretz Narretz closed this Jul 16, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants