Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

The dollar sign is a bit deceptive. #4215

Closed
wants to merge 1 commit into from

Conversation

mstaessen
Copy link
Contributor

It could just be me, but I thought $save() was a hidden Angular method of ngModelController. Quick find in the source code was good enough to find out it isn't, but it might be better to use another example here...

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

I think model.$save() looks like a method of ngModelController. A simple search shows that it is not, but it might be better to illustrate ng-click with a less deceptive example.
@mstaessen
Copy link
Contributor Author

Just signed the CLA. My name is Michiel Staessen.
Also edited the commit message.

@btford
Copy link
Contributor

btford commented Oct 1, 2013

👍

@ghost ghost assigned btford Oct 1, 2013
@petebacondarwin
Copy link
Contributor

Actually $save is a method on a $resource instance object. But you are right that it is somewhat misleading in the context of the a directive.

@petebacondarwin
Copy link
Contributor

@mstaessen - one small thing is that the commit message subject should not end in a full stop. :-)

jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this pull request Jan 27, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants