Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

fix($sniffer): history problems on Boxee box #3687

Closed
wants to merge 2 commits into from
Closed

fix($sniffer): history problems on Boxee box #3687

wants to merge 2 commits into from

Conversation

dusanbartos
Copy link
Contributor

similar to the one on Android with history.pushState
#956
same behavior experienced with Boxee box browser

@ghost ghost assigned jeffbcross Aug 21, 2013
@jeffbcross
Copy link
Contributor

PR Checklist (Minor Feature)

  • Contributor signed CLA now or in the past (if you just signed, leave a comment here with your real name for cross reference)
  • Feature improves existing core functionality
  • API is compatible with existing Angular apis and relevant standards (if applicable)
  • PR doesn't contain a breaking change
  • PR contains unit tests
  • PR contains e2e tests (if suitable)
  • PR contains documentation update
  • PR passes all tests on Travis (sanity)
  • PR passes all tests on ci.angularjs.org (cross-browser compatibility)
  • PR is rebased against recent master
  • PR is squashed into one commit per logical change
  • PR's commit messages are descriptive and allows us to autogenerate release notes (required commit message format)
  • All changes requested in review have been implemented

@jeffbcross
Copy link
Contributor

Thanks for the PR! A couple of issues:

  • Have you signed the CLA?
  • Could you write a test in snifferSpec? You can look at other tests in that spec to see how the window object is mocked to reflect an Android user agent.
  • Can you add more information to the commit message body, like you have in the pull request body?

@dusanbartos
Copy link
Contributor Author

I have signed the CLA few hours ago.
But I can't figure out how to change commit message body

@jeffbcross
Copy link
Contributor

git commit --amend will bring up an editor to change the last message. Then just add the body below your summary, with a blank line in-between.
You'll need to push the commit with -f, e.g. git push origin master -f

Can you tell me the name you used to sign the CLA so I can verify?

@ghost ghost assigned jeffbcross Aug 22, 2013
History API not working properly on Boxee box browser (old Webkit)
problem similar to the one on Android < 4
@dusanbartos
Copy link
Contributor Author

CLA name is Dusan Bartos

@jeffbcross
Copy link
Contributor

Thanks, I made a couple of fixes and am testing on CI server now http://ci.angularjs.org/job/angular.js-jeff/51/

@jeffbcross
Copy link
Contributor

Merged

@jeffbcross jeffbcross closed this Aug 23, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants