This repository was archived by the owner on Apr 12, 2024. It is now read-only.
test(ngSanitize): disable a failing Edge test in all versions, including 18 #16786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
reviewed
Dec 6, 2018
jbedard
approved these changes
Dec 6, 2018
…ing 18 It's been only disabled on Edge 16/17 so far which made it fail in Edge 18.
mgol
changed the title
mgol
added a commit
that referenced
this pull request
Dec 9, 2018
…ing 18 It's been only disabled on Edge 16/17 so far which made it fail in Edge 18. Closes #16786
This was referenced Dec 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Test fix.
What is the current behavior? (You can also link to an open issue here)
Edge 18 fails tests.
What is the new behavior (if this is a feature change)?
Edge 18 passes tests (or at least the one I fixed).
Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Fix/Feature: Docs have been added/updatedFix/Feature: Tests have been added; existing tests passOther information:
The test has been only disabled on Edge 16/17 so far which made it fail in Edge 18.