Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(migration): 'ctrk' Should Be 'ctrl' in docs #16750

Closed
wants to merge 2 commits into from
Closed

docs(migration): 'ctrk' Should Be 'ctrl' in docs #16750

wants to merge 2 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 31, 2018

Resolves #16748

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update

What is the current behavior? (You can also link to an open issue here)
#16748

What is the new behavior (if this is a feature change)?
Typos be gone :)

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

@gkalpak
Copy link
Member

gkalpak commented Oct 31, 2018

Good catch 👍
Can you please ensure the commit messages follow the commit message guidelines?

@ghost ghost changed the title Fix Typos in Docs: 'ctrk' Should Be 'ctrl' docs(migration): 'ctrk' Should Be 'ctrl' in docs Nov 2, 2018
@ghost
Copy link
Author

ghost commented Nov 2, 2018

Couldn't find the simplest way to change my commit messages, so I made a new branch and PR #16754

@ghost ghost closed this Nov 2, 2018
@petebacondarwin
Copy link
Contributor

@dapperdandev you could have tried something like

git commit --amend

Update the message in the editor that pops up. You can configure this to be VS Code for example.

git push --force-with-lease

@ghost
Copy link
Author

ghost commented Nov 3, 2018

@petebacondarwin Thanks! That's a helpful tip I can use for other projects. The main headache for me in this case was that I was on my work computer configured with my work git account via SSH. I haven't been able to figure out how to toggle SSH/accounts when cloning and pushing.

So I found it much simpler to literally edit the files in github and make the pr from there.

@petebacondarwin
Copy link
Contributor

Ahah! I see.

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs Incorrectly use 'ctrk' instead of 'ctrl'
3 participants