Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(*): update Sauce Connect from 4.4.12 to 4.5.1 #16730

Merged
merged 1 commit into from
Oct 15, 2018

Conversation

mgol
Copy link
Member

@mgol mgol commented Oct 11, 2018

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

An infra fix/update.

What is the current behavior? (You can also link to an open issue here)

The builds often terminate with a message like:

Failed: The test with session id eaf6f785a1f146afaa66f0f9dabc8835 has already finished, and can't receive further commands.
This was build https://travis-ci.org/angular/angular.js/jobs/430937161

What is the new behavior (if this is a feature change)?

I hope the Sauce Connect update will eliminate those issues, especially that its changelog explicitly mentions they fixed "a major bug in connection state logic that caused clients to exit prematurely".
See https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy+Change+Logs

Does this PR introduce a breaking change?

No.

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

Sauce Connect 4.5.0 fixes "a major bug in connection state logic that caused
clients to exit prematurely".
See https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy+Change+Logs
@mgol
Copy link
Member Author

mgol commented Oct 11, 2018

It didn't help. :(

ERROR The test with session id 9a9e114670844e26875b9dd12ea4a841 has already finished, and can't receive further commands.

But maybe we should upgrade anyway.

@Narretz Narretz merged commit 100cf72 into angular:master Oct 15, 2018
@mgol mgol deleted the sauce-connect-update branch October 15, 2018 09:16
mgol added a commit that referenced this pull request Oct 15, 2018
Sauce Connect 4.5.0 fixes "a major bug in connection state logic that caused
clients to exit prematurely".
See https://wiki.saucelabs.com/display/DOCS/Sauce+Connect+Proxy+Change+Logs
This will possibly improve the stability of our test runs.

Closes #16730
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants