Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(tutorial/Tutorial): add a note to explain how to solve problems that arise when running end to end tests using Chrome 65 #16525

Closed
wants to merge 1 commit into from

Conversation

jknepfle
Copy link

@jknepfle jknepfle commented Apr 6, 2018

Add a note to explain how to solve problems that arise when running end to end tests using Chrome 65.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs

What is the current behavior? (You can also link to an open issue here)
When using Chrome 65, errors are thrown due to an old version of chromedriver.

What is the new behavior (if this is a feature change)?
Explain how to update the version of chromedriver being used

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Fix/Feature: Docs have been added/updated
  • Fix/Feature: Tests have been added; existing tests pass

Other information:

Add a note to explain how to solve problems that arise when running end to end tests using Chrome 65.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@jknepfle
Copy link
Author

jknepfle commented Apr 6, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 6, 2018
@Narretz
Copy link
Contributor

Narretz commented Apr 6, 2018

We should probably update the tutorial with the correct version instead.

@gkalpak
Copy link
Member

gkalpak commented Apr 7, 2018

I have a PR to update angular-phonecat (there are some CI/infrastructure issues I need to fix once I get back from vacation, next week): angular/angular-phonecat#430

Once that's merged, everything should work as expected.
(We might also need to update the code snippets in the tutorial text; I will do that once the code changes are merged.)

@gkalpak gkalpak closed this Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants