This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(ngRepeat): improve info about tracking #16397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- deduplicate info between docs section and arguments - don't draw too much attention to track by ... - ... but highlight its drawbacks when used with one-time bindings - add example to show how tracking affects collection updates - clarify duplicates support for specific tracking expressions Closes angular#16332 Closes angular#16334
petebacondarwin
suggested changes
Jan 12, 2018
src/ng/directive/ngRepeat.js
Outdated
| * ``` | ||
| * All different types of tracking functions, their syntax, and and their support for duplicate | ||
| * items in collections can be found in the | ||
| * {@link ngRepeat#ngRepeat-arguments ngRepeat expression descriotion}. |
src/ng/directive/ngRepeat.js
Outdated
| * </div> | ||
| * When DOM elements are re-used, ngRepeat updates the scope for the element, which will | ||
| * automatically update any active bindings on the template. However, other | ||
| * functionality will not be updated, because it is a static at this point: |
There was a problem hiding this comment.
"a static" is a bit ambiguous here. Perhaps we could say "because the element is not recreated and recompiled"
Narretz
added a commit
to Narretz/angular.js
that referenced
this pull request
Jan 17, 2018
- deduplicate info between docs section and arguments - don't draw too much attention to track by $index ... - ... but highlight its drawbacks - add example to show how tracking affects collection updates - clarify duplicates support for specific tracking expressions Closes angular#16332 Closes angular#16334 Closes angular#16397
Narretz
added a commit
that referenced
this pull request
Jan 17, 2018
- deduplicate info between docs section and arguments - don't draw too much attention to track by $index ... - ... but highlight its drawbacks - add example to show how tracking affects collection updates - clarify duplicates support for specific tracking expressions Closes #16332 Closes #16334 Closes #16397
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #16334 because I came to the conclusions that the relevant docs needed a bigger overhaul.
Closes #16332
Closes #16334
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: