-
Notifications
You must be signed in to change notification settings - Fork 27.4k
docs(guide/Unit Testing): Changed $scope = {} to $scope = $rootScope.… #16315
Conversation
…$new() {} will just create an empty object. This will break if the module uses for example $watch or others.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
I guess that although in this case it is not necessary it doesn't do any harm and is more general. |
Looks like the CLA didn't go through. Did you make sure the email address is the same as the one in the commit? |
I signed it. |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Thanks @lisapfisterer ! |
…$new()
{} will just create an empty object. This will break if the module uses for example $watch or others.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change?
Please check if the PR fulfills these requirements
Other information: