Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(guide/Unit Testing): Changed $scope = {} to $scope = $rootScope.… #16315

Merged
merged 1 commit into from
Nov 2, 2017

Conversation

lisapfisterer
Copy link
Contributor

…$new()

{} will just create an empty object. This will break if the module uses for example $watch or others.

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change?

Please check if the PR fulfills these requirements

Other information:

…$new()

{} will just create an empty object. This will break if the module uses for example $watch or others.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@lisapfisterer
Copy link
Contributor Author

I signed it!

@petebacondarwin
Copy link
Contributor

I guess that although in this case it is not necessary it doesn't do any harm and is more general.

@Narretz
Copy link
Contributor

Narretz commented Nov 2, 2017

Looks like the CLA didn't go through. Did you make sure the email address is the same as the one in the commit?

@lisapfisterer
Copy link
Contributor Author

I signed it.

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Nov 2, 2017
@Narretz Narretz merged commit 2c9c3a0 into angular:master Nov 2, 2017
@Narretz
Copy link
Contributor

Narretz commented Nov 2, 2017

Thanks @lisapfisterer !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants