This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs($compileProvider): more information on debugInfoEnabled #16154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
suggested changes
Aug 8, 2017
src/ng/compile.js
Outdated
| * * `$binding` data property containing an array of the binding expressions | ||
| * * `scope()` and `isolateScope()` allowing access to scope from DOM Element |
There was a problem hiding this comment.
It doesn't add the methods. The methods are always present. It adds the $scope or $isolateScope (or $isolateScopeNoTemplate) data properties (that can be used by the .scope() and .isolateScope() methods).
Add more information about what `debugInfoEnabled` affects.
oBusk
changed the title
|
@gkalpak I've ammended according to your comments. Thanks for the feedback. |
gkalpak
suggested changes
Aug 23, 2017
src/ng/compile.js
Outdated
| * * `$binding` data property containing an array of the binding expressions | ||
| * * `$scope`, `$isolateScope` or `$isolateScopeNoTemplate` data properties which are accessable via the |
There was a problem hiding this comment.
This is too much implementation details imo. Please change to something like:
Data properties used by the {@link angular.element#methods
scope()/isolateScope()methods} to return the element's scope.
There was a problem hiding this comment.
That is a very good point
Use wording with less implementation details, based on review feedback.
gkalpak
pushed a commit
that referenced
this pull request
Aug 23, 2017
Add more info on what `debugInfoEnabled()` affects. Closes #16154
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Improves documentation about what
$compileProvider.debugInfoEnabled(true)does.Other information:
Based on compile.js source code.
Please feel free to improve the wording or come with feedback.
Related: #16155