Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(misc/FAQ): Correcting Misspell #16070

Merged
merged 2 commits into from
Jun 29, 2017
Merged

docs(misc/FAQ): Correcting Misspell #16070

merged 2 commits into from
Jun 29, 2017

Conversation

IdanCo
Copy link
Contributor

@IdanCo IdanCo commented Jun 26, 2017

The HTML brackets are still just 'Angular' :-)

Fixing over-correction made in this PR

The brackets are still just 'Angular' :-)

Fixing over-correction made in [this PR](angular@0304383)
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@IdanCo
Copy link
Contributor Author

IdanCo commented Jun 26, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

1 similar comment
@googlebot
Copy link

CLAs look good, thanks!

@frederikprijck
Copy link
Contributor

frederikprijck commented Jun 26, 2017

Thanks for the PR.

However, I have a few remarks regarding the original text, so it's not related to your change in particular.

What's the use of mentioning

Because HTML has AngularJS brackets and "ng" sounds like "AngularJS" ?

Being familiar with both AngularJS and Angular arises following questions for me:

  • What are AngularJS brackets ?
  • What are Angular brackets ?
  • How do both brackets differ ?
  • Why are the brackets even mentioned when explaining why the name is AngularJS ? Afaik AngularJS isn't named AngularJS just coz of the brackets. (and the brackets are identical in Angular ...)
  • How does ng sounds like AngularJS ?

I'm not sure about the added value of having this in the FAQ (not that it hurts to keep it that way, it's been there for ever).

@IdanCo
Copy link
Contributor Author

IdanCo commented Jun 26, 2017

so it's not related to your change in particular.

I'll give it a try anyway -

What are AngularJS brackets ?

No such thing. It's a mistake from when all 'Angular' strings were replaced by 'AngularJS'

What are Angular brackets ?

These are <>

How do both brackets differ ?

The former does not exist, the latter does exist

Why are the brackets even mentioned when explaining why the name is AngularJS ?

Because the angular brackets in HTML were the insperations for the name Angular.

Afaik AngularJS isn't named AngularJS just coz of the brackets. (and the brackets are identical in Angular ...)

See above...

How does ng sounds like AngularJS.

It doesn't. It sounds like plain 'Angular', but i didn't feel comfortable changing that

@frederikprijck
Copy link
Contributor

frederikprijck commented Jun 26, 2017

These are <>

Aren't we talking about Angle brackets (see: https://en.wiktionary.org/wiki/angle_bracket ) and not Angular brackets ?

Edit: My bad, I didn't relate Angle to Angular 🙈

@IdanCo
Copy link
Contributor Author

IdanCo commented Jun 26, 2017

angle-angular, tomayto-tomahto

@frederikprijck
Copy link
Contributor

frederikprijck commented Jun 26, 2017

I didn't place that comment as a tomayto-tomahto remark. 🙈
But I do see what you mean now: An Angle is Angular, hence Angular brackets (I honostly didn't see the light untill now).

Makes totally sense. Thanks for clarifying @IdanCo .

I do think having this in the faq is confusing when it comes to AngularJS vs Angular, but this note in the FAQ has nothing to do with AngularJS vs Angular.
I would add something refering Angle brackets (which leads to Angular as a name for both AngularJS and Angular) tbh, as this was added prior to Angular's existence (that's great for people like me who are not aware of angle brackets, making it hard to relate Angular brackets to Angle brackets).

Honostly, I looked at this part in the FAQ as: "Why is this AngularJS and not Angular1" (comparable to presskit stuff at https://angular.io/presskit), but it's basicly explaining where the origin of AngularJS (and Angular) was found.

Leaving that aside, I'd say AngularJS brackets is idd not what we want in the FAQ. 🙈
Imho it should be angular brackets, not Angular. (nitpicking, I know :( )

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@Narretz Narretz merged commit 62c9d1d into angular:master Jun 29, 2017
@Narretz
Copy link
Contributor

Narretz commented Jun 29, 2017

Merged with "angular" - Thanks for the PR!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants