-
Notifications
You must be signed in to change notification settings - Fork 27.4k
Conversation
The brackets are still just 'Angular' :-) Fixing over-correction made in [this PR](angular@0304383)
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
1 similar comment
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
CLAs look good, thanks! |
1 similar comment
CLAs look good, thanks! |
Thanks for the PR. However, I have a few remarks regarding the original text, so it's not related to your change in particular. What's the use of mentioning
Being familiar with both AngularJS and Angular arises following questions for me:
I'm not sure about the added value of having this in the FAQ (not that it hurts to keep it that way, it's been there for ever). |
I'll give it a try anyway -
No such thing. It's a mistake from when all 'Angular' strings were replaced by 'AngularJS'
These are <>
The former does not exist, the latter does exist
Because the angular brackets in HTML were the insperations for the name Angular.
See above...
It doesn't. It sounds like plain 'Angular', but i didn't feel comfortable changing that |
Aren't we talking about Edit: My bad, I didn't relate Angle to Angular 🙈 |
angle-angular, tomayto-tomahto |
I didn't place that comment as a tomayto-tomahto remark. 🙈 Makes totally sense. Thanks for clarifying @IdanCo . I do think having this in the faq is confusing when it comes to AngularJS vs Angular, but this note in the FAQ has nothing to do with AngularJS vs Angular. Honostly, I looked at this part in the FAQ as: "Why is this AngularJS and not Angular1" (comparable to presskit stuff at https://angular.io/presskit), but it's basicly explaining where the origin of AngularJS (and Angular) was found. Leaving that aside, I'd say |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
1 similar comment
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Merged with "angular" - Thanks for the PR! |
The HTML brackets are still just 'Angular' :-)
Fixing over-correction made in this PR