Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(i18n): fix and update CLDR to v30.0.1 #15997

Closed
wants to merge 5 commits into from
Closed

chore(i18n): fix and update CLDR to v30.0.1 #15997

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
888b704
test(i18n): remove bad assertion
gkalpak May 19, 2017
1d1cd70
chore(i18n): fix relative paths in scripts
gkalpak May 19, 2017
3b12b6b
chore(i18n): fix parser for currency patterns without fraction digits
gkalpak May 19, 2017
aaec70c
chore(i18n): update CLDR to v30.0.1
gkalpak May 19, 2017
7be74d6
fixup! chore(i18n): fix parser for currency patterns without fraction…
gkalpak May 24, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion i18n/spec/closureI18nExtractorSpec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,6 @@ describe('findLocaleId', function() {
it('should not find localeId if data is missing', function() {
expect(findLocaleId('', 'num')).toBeUndefined();
expect(findLocaleId('aa', 'datetime')).toBeUndefined();
expect(findLocaleId('aa', 'randomType')).toBeUndefined();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this assertion bad? Or, what caused it to be bad?

Copy link
Member Author

@gkalpak gkalpak May 22, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This throws an "unknown type in findLocaleId: randomType" error. This is what the next test verifies.
I assume that at some point someone decided to change the implementation, so that unknown types cause an error (vs returning undefined), but didn't update this test.

Maybe we should run these tests on CI.

expect(findLocaleId('NumberFormatSymbols_en', 'datetime')).toBeUndefined();
expect(findLocaleId('DateTimeSymbols_en', 'num')).toBeUndefined();
});
Expand Down