This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(docs-app): fix vertical scrolling offset after recent re-design #15945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the `yOffset` pointed to the `<header>` element, which had a height of 0 (since all its children have fixed positions). This caused scrolled items to have 0 vertical offset, essentially hiding the top part behind the static `<nav>` items. This commit fixes the vertical scrolling offset, by setting `yOffset` to the last (lowest) `<nav>` item.
gkalpak
added a commit
that referenced
this pull request
Apr 27, 2017
Previously, the `yOffset` pointed to the `<header>` element, which had a height of 0 (since all its children have fixed positions). This caused scrolled items to have 0 vertical offset, essentially hiding the top part behind the static `<nav>` items. This commit fixes the vertical scrolling offset, by setting `yOffset` to the last (lowest) `<nav>` item. Closes #15945
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
yOffsetpointed to the<header>element, which had a heightof 0 (since all its children have fixed positions). This caused scrolled items
to have 0 vertical offset, essentially hiding the top part behind the static
<nav>items.This commit fixes the vertical scrolling offset, by setting
yOffsetto thelast (lowest)
<nav>item.