Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore: unit test latest + latest-1 version of FF, Chrome, Edge #15927

Merged
merged 1 commit into from
Oct 18, 2017

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Apr 20, 2017

At the moment, we use fixed versions of these browsers to test - especially for FF and Chrome it's useful to test the latest, as they release faster.
For the future, we could also look into using latest-1 additionally.

@gkalpak
Copy link
Member

gkalpak commented Apr 20, 2017

I am not sure how I feel about this (especially for Edge since it is tied to the Windows version).
But for Chrome and Firefox we are probably fine (although I would feel more confident with latest-1).

@Narretz
Copy link
Contributor Author

Narretz commented Apr 21, 2017

latest-1 sounds good - at the moment, there's a failing test in FF 52.0.0, which I can't reproduce in my local FF 52.0.2. Or does Saucelabs not report the patch version?
In any case, Saucelabs is kind of slow updating to the latest version, so we're probably better of using latest-1

@Narretz Narretz added this to the 1.6.5 milestone Apr 21, 2017
@Narretz Narretz changed the title chore: always test latest version of FF, Chrome, Edge chore: test latest-1 version of FF, Chrome Apr 24, 2017
@Narretz Narretz force-pushed the chore-test-latest branch from e95252b to 0655518 Compare May 9, 2017 17:04
@Narretz Narretz force-pushed the chore-test-latest branch 2 times, most recently from 8163e42 to 9126294 Compare June 8, 2017 14:20
@Narretz Narretz force-pushed the chore-test-latest branch 2 times, most recently from 752852c to e6a44ab Compare June 16, 2017 23:03
@Narretz
Copy link
Contributor Author

Narretz commented Jun 17, 2017

With jasmine 2.6.4+, all browsers fail to complete: https://travis-ci.org/angular/angular.js/jobs/243851080#L619
Locally, the csp tests in AngularSpec.js are to blame:

describe('csp', function() {

When excluded, the tests pass. Probably another jasmine bug.

Bug report: jasmine/jasmine#1430

Btw, I don't even know why I updated jasmine. I think an old version was incompatible with Chrome 58?

@Narretz Narretz modified the milestones: Backlog, 1.6.5 Jun 21, 2017
@Narretz Narretz force-pushed the chore-test-latest branch 2 times, most recently from e6a44ab to 81f12fb Compare October 16, 2017 10:59
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

3 similar comments
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@Narretz Narretz force-pushed the chore-test-latest branch 3 times, most recently from d91f75c to ab0ff91 Compare October 16, 2017 12:14
@Narretz Narretz changed the title chore: test latest-1 version of FF, Chrome chore: unit test latest + latest-1 version of FF, Chrome, Edge Oct 18, 2017
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to squash

Previously, we used fixed versions that became outdated quickly for
FF and Chrome.

Safari currently still has failures, see
angular#15717
@Narretz Narretz merged commit 84294ec into angular:master Oct 18, 2017
Narretz added a commit that referenced this pull request Oct 19, 2017
Previously, we used fixed versions that became outdated quickly for
FF and Chrome.

Safari 10/11 is not included because during the latest test there were 
failures, see #15717

Jasmine is fixed to 2.5.2 because 2.6.0+ is not compatible with the suite:
#15927 (comment)

Closes #15927
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants