-
Notifications
You must be signed in to change notification settings - Fork 27.4k
chore: unit test latest + latest-1 version of FF, Chrome, Edge #15927
Conversation
553ddf7
to
9b6766c
Compare
I am not sure how I feel about this (especially for Edge since it is tied to the Windows version). |
|
8163e42
to
9126294
Compare
752852c
to
e6a44ab
Compare
With jasmine 2.6.4+, all browsers fail to complete: https://travis-ci.org/angular/angular.js/jobs/243851080#L619 angular.js/test/AngularSpec.js Line 1026 in e58bcfa
When excluded, the tests pass. Probably another jasmine bug. Bug report: jasmine/jasmine#1430 Btw, I don't even know why I updated jasmine. |
e6a44ab
to
81f12fb
Compare
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
3 similar comments
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
d91f75c
to
ab0ff91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to squash
Previously, we used fixed versions that became outdated quickly for FF and Chrome. Safari currently still has failures, see angular#15717
5dbb590
to
36bf9d9
Compare
Previously, we used fixed versions that became outdated quickly for FF and Chrome. Safari 10/11 is not included because during the latest test there were failures, see #15717 Jasmine is fixed to 2.5.2 because 2.6.0+ is not compatible with the suite: #15927 (comment) Closes #15927
At the moment, we use fixed versions of these browsers to test - especially for FF and Chrome it's useful to test the latest, as they release faster.
For the future, we could also look into using
latest-1
additionally.