Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

chore(github): update the issue template #15824

Merged
merged 1 commit into from
Mar 22, 2017
Merged

chore(github): update the issue template #15824

merged 1 commit into from
Mar 22, 2017

Conversation

Narretz
Copy link
Contributor

@Narretz Narretz commented Mar 16, 2017 •
edited
Loading

Updates the issue template.

  • make it more like the Angular one
  • include extra information into comments, so the actual output is cleaner and you can find the relevant info faster when triaging
  • make it easier to differentiate between bugs and features
  • remove section that are only relevant for features ... this is often filled out with redundant info
  • make sections shorter and hopefully clearer

@Narretz Narretz force-pushed the chore-issue-template branch from ce94b48 to 7df9b3c Compare March 16, 2017 22:21
gkalpak
gkalpak reviewed Mar 20, 2017
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of nits. 💯 otherwise 😃

.github/ISSUE_TEMPLATE.md Outdated
- Before submitting, please **SEARCH GITHUB** for a similar issue or PR. -->

**I'm submitting a ...** (check one with "x")
```
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really hate that on the angular ISSUE_TEMPLATE. Why put this inside a code-block?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's because when it's inline you have an actual checkbox - which is good - but Github will show the issue as having "1 of 3" in the issue list. That might be a problem when we / someone adds more checkboxes, because then you cannot distinguish between the issue type and some sort of to-do list. Basically what we want here is a radio group ...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't feel too strongly about it. I slightly prefer the checkboxes over code-blocks, but I am happy with this PR either way 👍

.github/ISSUE_TEMPLATE.md Outdated
**Browser:** [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]
<!-- All browsers where this could be reproduced -->

**Environment:**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure this is very relevant for AngularJS. I would rather remove it from the template and "manually" request the extra info if necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure - I'll add a note about the OS to the browser section

@Narretz Narretz force-pushed the chore-issue-template branch 2 times, most recently from 10d1a69 to 9c47f21 Compare March 20, 2017 18:55
@Narretz Narretz force-pushed the chore-issue-template branch from 9c47f21 to c2f89e9 Compare March 20, 2017 18:56
@Narretz Narretz merged commit c35786a into angular:master Mar 22, 2017
@Narretz Narretz deleted the chore-issue-template branch March 22, 2017 16:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak left review comments

Assignees
No one assigned
Labels
cla: yes needs: review type: chore
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Narretz @gkalpak @googlebot