Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

docs(ngClass): Add docs for ngClassOdd and ngClassEven regarding anim… #15654

Closed
wants to merge 2 commits into from
Closed

docs(ngClass): Add docs for ngClassOdd and ngClassEven regarding anim… #15654

wants to merge 2 commits into from

Conversation

frederikprijck
Copy link
Contributor

@frederikprijck frederikprijck commented Jan 30, 2017 •
edited by gkalpak
Loading

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update

What is the current behavior? (You can also link to an open issue here)
The documentation has no information regarding using animation together with the ngClassOdd and ngClassEven directive.

What is the new behavior (if this is a feature change)?
This commit adds the same docs used by the ngClass directive to the ngClassOdd and ngClassEven docs and adds an extra example for both ngClassOdd and ngClassEven.

Does this PR introduce a breaking change?
No

Please check if the PR fulfills these requirements

Other information:

@gkalpak gkalpak added this to the Backlog milestone Jan 31, 2017
@gkalpak gkalpak self-assigned this Jan 31, 2017
@gkalpak gkalpak mentioned this pull request Jan 31, 2017
Closed
5 tasks
@frederikprijck @gkalpak
docs(ngClass): add docs regarding animation for ngClassEven and `ng…
f78b559 
…ClassOdd`

Previously, the documentation has no information regarding using
`ngAnimate` together with the `ngClassEven` and `ngClassOdd` directives.

This commit adds the same docs used by the `ngClass` directive to the
`ngClassEven` and `ngClassOdd` docs and adds an extra example for both
`ngClassEven` and `ngClassOdd` that showcases animations.
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

1 similar comment
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

@googlebot googlebot added cla: no and removed cla: yes labels Feb 6, 2018
gkalpak
gkalpak approved these changes Feb 6, 2018
View reviewed changes
Copy link
Member

@gkalpak gkalpak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made some changes to the examples, updated some links in the animations guide, and rebased on master.

gkalpak pushed a commit that referenced this pull request Feb 6, 2018
@frederikprijck @gkalpak
docs(ngClass): add docs regarding animation for ngClassEven and `ng…
0722ab0 
…ClassOdd`

Previously, the documentation has no information regarding using
`ngAnimate` together with the `ngClassEven` and `ngClassOdd` directives.

This commit adds the same docs used by the `ngClass` directive to the
`ngClassEven` and `ngClassOdd` docs and adds an extra example for both
`ngClassEven` and `ngClassOdd` that showcases animations.

Closes #15654
@gkalpak gkalpak closed this in 02f4ca4 Feb 6, 2018
@frederikprijck frederikprijck deleted the docs/ngClassOddEven branch February 6, 2018 20:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@gkalpak gkalpak gkalpak approved these changes

Assignees

@gkalpak gkalpak

Labels
cla: no component: misc core type: docs
Projects
None yet
Milestone
Backlog - won't fix
Development

Successfully merging this pull request may close these issues.
3 participants
@frederikprijck @googlebot @gkalpak