This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(directive): show arguments as a subsection of the usage section #15646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, on the docs of directives which include the `animation` section, `arguments` are shown as an `h3` element below the `animation` `h2` element, making it look like it's a subsection of `animations`. This commit ensures that the àrgument` `h3`element is rendered correctly after the `usage` `h2` element. Fixes #15645
|
Good catch, thanks |
gkalpak
pushed a commit
that referenced
this pull request
Jan 30, 2017
Previously, on the docs of directives which include the `animation` section, `arguments` are shown as an `h3` element below the `animation` `h2` element, making it look like it's a subsection of `animations`. This commit ensures that the àrgument` `h3`element is rendered correctly after the `usage` `h2` element. Fixes #15645 Closes #15646
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
Previously, on the docs of directives which include the `animation` section, `arguments` are shown as an `h3` element below the `animation` `h2` element, making it look like it's a subsection of `animations`. This commit ensures that the àrgument` `h3`element is rendered correctly after the `usage` `h2` element. Fixes angular#15645 Closes angular#15646
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
docs update
What is the current behavior? (You can also link to an open issue here)
Previously, on the docs of directives which include the
animationsection,argumentsare shown as anh3element below theanimationh2element, making it look like it's a subsection ofanimations.#15645
What is the new behavior (if this is a feature change)?
This commit ensures that the àrgument
element is rendered correctly after theusageelement by moving the ànimationsection to the end of the template file.Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: