Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

Remove unneeded window reference #15610

Closed
wants to merge 2 commits into from
Closed

Remove unneeded window reference #15610

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ebeac3
Remove unneeded window reference
david-mark Jan 17, 2017
6e41f09
Removed UA sniff from unit test
david-mark Jan 17, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Angular.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ var
* documentMode is an IE-only property
* http://msdn.microsoft.com/en-us/library/ie/cc196988(v=vs.85).aspx
*/
msie = window.document.documentMode;
msie = document.documentMode;


/**
Expand Down
5 changes: 2 additions & 3 deletions test/helpers/matchers.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,8 +369,7 @@ beforeEach(function() {
errors.push('Expected option property "selected" to be truthy');
}

// Support: IE 9 only
if (msie !== 9 && actual.hasAttribute('selected') === false) {
if (actual.hasAttribute('selected') === false) {
errors.push('Expected option to have attribute "selected"');
}

Expand All @@ -388,7 +387,7 @@ beforeEach(function() {
}

// Support: IE 9 only
if (msie !== 9 && actual.hasAttribute('selected')) {
if (actual.hasAttribute('selected')) {
errors.push('Expected option not to have attribute "selected"');
}

Expand Down