This repository was archived by the owner on Apr 12, 2024. It is now read-only.
docs(guide/Migrating from Previous Versions): improve grammar in jque… #15518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gkalpak
reviewed
Dec 19, 2016
| @@ -88,7 +88,7 @@ commits for more info. | |||
|
|
|||
| - **jqLite** is more aligned to jQuery 3, which required the following changes | |||
| (see [details](guide/migration#migrate1.5to1.6-ng-misc-jqLite) below): | |||
| - Keys passed to `.data()` and `.css()` are now camelCased in the same way as jQuery does it. | |||
| - Keys passed to `.data()` and `.css()` are now camelCased in the same way as jQuery. | |||
There was a problem hiding this comment.
While I agree the original sentence is not ideal, I find the new version ambiguous. It can be interpreted as:
[...] are now camelCased in the same way as jQuery is camelCased
|
Closing (see my comment), but feel free to ping me if you can come up with a better wording that is not ambiguous. |
|
"In the same way as the jQuery methods do"?
…On 19 Dec 2016 3:18 pm, "Georgios Kalpakas" ***@***.***> wrote:
Closig due (see my comment
<https://github.com/angular/angular.js/pull/15518/files/084fd86f7ebedad1a1e1ae5a8bc3f57e7fc7435b..554b19dfd8efaee7af261362a3ebbdf9e72f3137#r93049966>),
but feel free to ping me if you can come up with a better wording that is
not ambiguous.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#15518 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAZQTGRdEDS_SGCmjwZCsrx96-2x1DNHks5rJqAygaJpZM4LQIJW>
.
|
|
SGTM |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ry docs
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update
What is the current behavior? (You can also link to an open issue here)
Bad grammar
What is the new behavior (if this is a feature change)?
Better grammar
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: