This repository was archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngModel): add $overrideModelOptions support
#15415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petebacondarwin
force-pushed
the
model-option-override
branch
2 times, most recently
from
caa180a to
c4debc4
Compare
gkalpak
reviewed
Nov 22, 2016
src/ng/directive/ngModel.js
Outdated
| * | ||
| * The previous `ModelOptions` value will not be modified. Instead, the | ||
| * new `ModelOptions` object will inherit from the previous value of | ||
| * `NgModelController.$options`. |
There was a problem hiding this comment.
IIRC, this is the only place we publicly document NgModelController.$options. I don't think it is a good idea (especially considering we don't specify what its type is or what the API of this ModelOptions type is).
There was a problem hiding this comment.
OK, I'll fix this
test/ng/directive/ngModelSpec.js
Outdated
| ctrl.$overrideModelOptions({ debounce: 1000, updateOn: 'blur' }); | ||
| expect(ctrl.$options.getOption('debounce')).toEqual(1000); | ||
| expect(ctrl.$options.getOption('updateOn')).toEqual('blur'); | ||
| expect(ctrl.$options.getOption('updateOnDefault')).toBe(false); |
test/ng/directive/ngModelSpec.js
Outdated
| it('should inherit from a parent model options', inject(function($compile, $rootScope) { | ||
| var element = $compile( | ||
| '<form name="form" ng-model-options="{debounce: 1000, updateOn: \'blur\'}">' + | ||
| '<input ng-model="value" name="input">' + |
There was a problem hiding this comment.
Nit: Inconsistent indentation 😁
test/ng/directive/ngModelSpec.js
Outdated
| '<input ng-model="value" name="input">' + | ||
| '</form>')($rootScope); | ||
| var ctrl = $rootScope.form.input; | ||
| ctrl.$overrideModelOptions({ debounce: 2000, '*': '$inherit' }); |
There was a problem hiding this comment.
Nit: Ideally, I would repeat the same test without the '*': '$inherit' part (just in case), but this should not block landing the PR.
petebacondarwin
force-pushed
the
model-option-override
branch
from
c4debc4 to
d2bde12
Compare
petebacondarwin
added a commit
to petebacondarwin/angular.js
that referenced
this pull request
Nov 22, 2016
This change allows developers to modify the model options for an `ngModel` directive programmatically. Closes angular#15415
petebacondarwin
changed the title
$overrideModelOptions support
gkalpak
approved these changes
Dec 23, 2016
|
@petebacondarwin This has been approved and can be merged. I assigned you as the creator. |
petebacondarwin
force-pushed
the
model-option-override
branch
from
d2bde12 to
2b00e88
Compare
petebacondarwin
added a commit
that referenced
this pull request
Feb 1, 2017
This change allows developers to modify the model options for an `ngModel` directive programmatically. Closes #15415
ellimist
pushed a commit
to ellimist/angular.js
that referenced
this pull request
Mar 15, 2017
This change allows developers to modify the model options for an `ngModel` directive programmatically. Closes angular#15415
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
feature
What is the current behavior? (You can also link to an open issue here)
no obvious way to programmatically change model options for an ngModel directive
What is the new behavior (if this is a feature change)?
Adds
$overrideModelOptionsmethodDoes this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements
Other information: