WIP - docs(guide/migration): add "Migrate 1.5 to 1.6" section #15399

gkalpak · 2016-11-16T16:21:28Z

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Docs update.

What is the current behavior? (You can also link to an open issue here)
No migration docs for 1.5 -> 1.6.

What is the new behavior (if this is a feature change)?
Migration docs for 1.5 -> 1.6.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

The commit message follows our guidelines: https://github.com/angular/angular.js/blob/master/CONTRIBUTING.md#commit-message-format
~~Tests for the changes have been added (for bug fixes / features)~~
Docs have been added / updated (for bug fixes / features)

Other information:
This needs to be updated with the changes that land on future RCs.

petebacondarwin · 2016-11-17T08:31:32Z

docs/content/guide/migration.ngdoc

+The most notable changes are:
+
+- Aligning jqLite with the latest version of jQuery (3.x).
+- Implementing long awaited features, such as support for inputs of type `range` or the ability to


... or and the ability to ...

petebacondarwin · 2016-11-17T08:32:29Z

docs/content/guide/migration.ngdoc

+- Aligning jqLite with the latest version of jQuery (3.x).
+- Implementing long awaited features, such as support for inputs of type `range` or the ability to
+  bind to any type of values using `ngRepeat` with `select`.
+- Disabling (by default) the pre-assignment of bindings on controller instances.


which helps with support for native ES6 classes?

petebacondarwin

looking good so far. A few comments

petebacondarwin · 2016-11-17T08:33:19Z

docs/content/guide/migration.ngdoc

+- Implementing long awaited features, such as support for inputs of type `range` or the ability to
+  bind to any type of values using `ngRepeat` with `select`.
+- Disabling (by default) the pre-assignment of bindings on controller instances.
+- Changing the default `$location` hash-prefix to `!`.


as the previous empty string default was unconventional and confusing

petebacondarwin · 2016-11-17T08:39:10Z

docs/content/guide/migration.ngdoc

+
+- **input[type=range]**: Due to [913016](https://github.com/angular/angular.js/commit/9130166767c4792c5d32d08a918fc7becf32c9a6)
+  and the built-in support for range inputs, the behavior of such elements when bound to `ngModel`
+  will be different than before.


How about making this section concise:

The improved support for range means that behaviour of input[range] element when bound to ngModel has changed. See [link to section below]

etc.

petebacondarwin · 2016-11-17T08:39:42Z

docs/content/guide/migration.ngdoc

+- **ngModelOptions**: Due to [87a2ff](https://github.com/angular/angular.js/commit/87a2ff76af5d0a9268d8eb84db5755077d27c84c),
+  if a setting is not applied on `ngModelOptions`, it will be inherited from the nearest
+  `ngModelOptions` ancestor. Previously, it would default to `undefined`.
+  The programmatic API for `ngModelOptions` has also changed.


I guess this needs changing

petebacondarwin · 2016-11-17T08:44:57Z

docs/content/guide/migration.ngdoc

+  (`''`) to the bang (`'!'`).
+
+- **jqLite**:
+    - Due to [fc0c11](https://github.com/angular/angular.js/commit/fc0c11db845d53061430b7f05e773dcb3fb5b860),


So in this one it could look something like:

jqLite is more aligned to jQuery 3 which required the following changes (see [link to section]):

keys for .data() and .css() are now camelCased

setting boolean attributes to empty string no longer removes the attribute

calling .val() on a multiple select will now return an empty array if no option is selected

petebacondarwin · 2016-11-17T08:45:50Z

docs/content/guide/migration.ngdoc

+Below is the full list of breaking changes:
+
+
+<br />


At this point I have to stop review and do childcare. But I guess that most of this is generated from the changelog right?

Most of this, but the messages are curated 😃

petebacondarwin · 2016-11-17T08:47:24Z

docs/content/guide/migration.ngdoc

+
+
+<br />
+### ServiceCore: s


ServiceCore: s??

Ooops! Misplaced multiple cursor.

petebacondarwin · 2016-11-17T08:48:32Z

docs/content/guide/migration.ngdoc

+  and `''` as "empty".
+
+
+Below is the full list of breaking changes:


It might be worth putting in a mini-contents list here with links to each of the sections below.

E.g.

core directives

forms

input

ngBind

ngModel

ngModelOptions

...

core services

...
etc

petebacondarwin · 2016-11-17T08:50:15Z

docs/content/guide/migration.ngdoc

+the `$route` service will no longer instantiate controllers nor call `resolve` or
+`template`/`templateUrl` functions for routes that successfully `redirectTo` other routes.
+
+


And well done if you managed to get this far :-)

gkalpak · 2016-11-17T09:50:01Z

docs/content/guide/migration.ngdoc

+<form ng-model-options="{updateOn: 'blur'}">
+  <input ng-model="..." />
+</form>
+```


I just realized this example is wrong :( ngModel inherits its closest ngModelOptions if it doesn't have its own.
(Good thing that commit got reverted 😃)

gkalpak · 2016-11-17T18:45:35Z

@petebd, PTAL

petebacondarwin · 2016-11-17T23:40:20Z

Let me TAL in the morning

petebacondarwin · 2016-11-17T23:40:52Z

If it is OK, I will merge it and we can iterate.
I think it will be better to get something out there.

petebacondarwin · 2016-11-18T10:51:31Z

docs/content/guide/migration.ngdoc

+  unconventional and confusing.
+- Reporting possibly unhandled promise rejections that would otherwise go unnoticed.
+
+Another major change is the removal of the **Expression Sandbox**. This should not affect applications


... should not require changes to your application (and may give it a small performance boost), but ...

petebacondarwin · 2016-11-18T11:48:56Z

docs/content/guide/migration.ngdoc

+  converts an invalid value (empty: `null`, `undefined`, `false` ..., out of bounds: greater than
+  max, less than min) to a valid value, the input will in turn set the model to this new valid value
+  via `$setViewValue`.
+  - This means a range input will never be required and never have a non-Number model value, once


"This means a range input will never be required"? Should this be "will never have the required validation error"?

petebacondarwin · 2016-11-18T11:51:49Z

docs/content/guide/migration.ngdoc

+#### **form**:
+
+<minor />
+Due to [9e24e7](https://github.com/angular/angular.js/commit/9e24e774a558143b3478536911a3a4c1714564ba),


Can we make all the "Due to XXXX, " bits bold? This will help to distinguish the start of a new BC.

petebacondarwin

Some small changes. But once they are done let's merge this in.

petebacondarwin · 2016-11-18T11:58:13Z

docs/content/guide/migration.ngdoc

+you actually want whitespace to appear as the transcluded content, then you can force it to be used
+by adding a comment to the whitespace.
+
+


We should provide an example of adding a comment to this. E.g.

<my-component><!- force-whitespace --> </my-component>

petebacondarwin · 2016-11-18T11:58:27Z

docs/content/guide/migration.ngdoc

+fallback content will be used instead. Previously, whitespace only transclusion would be treated as
+the transclusion being "not empty", which meant that fallback content was not used in that case. If
+you actually want whitespace to appear as the transcluded content, then you can force it to be used
+by adding a comment to the whitespace.


by adding an HTML comment to the whitespace.

petebacondarwin · 2016-11-18T12:03:19Z

docs/content/guide/migration.ngdoc

+whitespace in attributes is no longer trimmed automatically. This includes leading and trailing
+whitespace, and attributes that are purely whitespace. To migrate, attributes that require trimming
+must now be trimmed manually. A common case where stray whitespace can cause problems is when
+attribute values are compared, for example in an `$observe`r.


$observerr renders poorly. Instead let's say "for example in $observe."

petebacondarwin · 2016-11-18T12:08:36Z

docs/content/guide/migration.ngdoc

+
+<hr />
+<minor />
+Due to [fb6634](https://github.com/angular/angular.js/commit/fb663418710736161a6b5da49c345e92edf58dcb),


This is a BIG-ONE that needs to be listed at the top. It will affect every application that uses JSONP.

petebacondarwin · 2016-11-18T22:05:40Z

I'll merge as soon as Travis completes

Closes angular#15399

gkalpak changed the title ~~docs(guide/migration): add "Migrate 1.5 to 1.6" section~~ WIP - docs(guide/migration): add "Migrate 1.5 to 1.6" section Nov 16, 2016

googlebot added the cla: yes label Nov 16, 2016

gkalpak added component: misc core type: docs and removed cla: yes labels Nov 16, 2016

gkalpak added this to the 1.6.0-rc.1 milestone Nov 16, 2016

docs(guide/migration): add "Migrate 1.5 to 1.6" section

7f8ee0e

petebacondarwin reviewed Nov 17, 2016

View reviewed changes

gkalpak commented Nov 17, 2016

View reviewed changes

fixup! docs(guide/migration): add "Migrate 1.5 to 1.6" section

88c03c9

gkalpak force-pushed the docs-guide-migrate-to-1.6 branch from 5c3350b to 88c03c9 Compare November 17, 2016 16:41

googlebot added the cla: yes label Nov 17, 2016

petebacondarwin reviewed Nov 18, 2016

View reviewed changes

fixup! docs(guide/migration): add "Migrate 1.5 to 1.6" section

43f9ef3

petebacondarwin reviewed Nov 18, 2016

View reviewed changes

petebacondarwin suggested changes Nov 18, 2016

View reviewed changes

fixup! docs(guide/migration): add "Migrate 1.5 to 1.6" section

824df35

petebacondarwin approved these changes Nov 18, 2016

View reviewed changes

petebacondarwin closed this in a144c1c Nov 19, 2016

gkalpak deleted the docs-guide-migrate-to-1.6 branch November 21, 2016 11:59

ellimist pushed a commit to ellimist/angular.js that referenced this pull request Mar 15, 2017

docs(guide/migration): add "Migrate 1.5 to 1.6" section

5f02871

Closes angular#15399

		and `''` as "empty".


		Below is the full list of breaking changes:

		the `$route` service will no longer instantiate controllers nor call `resolve` or
		`template`/`templateUrl` functions for routes that successfully `redirectTo` other routes.

		you actually want whitespace to appear as the transcluded content, then you can force it to be used
		by adding a comment to the whitespace.



		<br />
		### ServiceCore: s

WIP - docs(guide/migration): add "Migrate 1.5 to 1.6" section #15399

WIP - docs(guide/migration): add "Migrate 1.5 to 1.6" section #15399

Uh oh!

Conversation

gkalpak commented Nov 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkalpak Nov 17, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gkalpak commented Nov 17, 2016

Uh oh!

petebacondarwin commented Nov 17, 2016

Uh oh!

petebacondarwin commented Nov 17, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petebacondarwin left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

petebacondarwin commented Nov 18, 2016

Uh oh!

Uh oh!

gkalpak commented Nov 16, 2016 •

edited

Loading

gkalpak Nov 17, 2016 •

edited

Loading