This repository was archived by the owner on Apr 12, 2024. It is now read-only.
refactor($animate): avoid unnecessary lookup #14902
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactoring. (Theoretically a perf improvement, but it is so insignificant, that it's not worth mentioning as such 😛 )
What is the current behavior? (You can also link to an open issue here)
In
$animate.enabled()
, we look up indisabledElementsLookup
even if we never use the value.What is the new behavior (if this is a feature change)?
In
$animate.enabled()
, we look up indisabledElementsLookup
only if we need the value.Does this PR introduce a breaking change?
No.
Please check if the PR fulfills these requirements
Tests for the changes have been added (for bug fixes / features)Docs have been added / updated (for bug fixes / features)Other information:
No 😕