Skip to content
This repository was archived by the owner on Apr 12, 2024. It is now read-only.

refactor($animate): avoid unnecessary lookup #14902

Conversation

gkalpak
Copy link
Member

@gkalpak gkalpak commented Jul 12, 2016

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
Refactoring. (Theoretically a perf improvement, but it is so insignificant, that it's not worth mentioning as such 😛 )

What is the current behavior? (You can also link to an open issue here)
In $animate.enabled(), we look up in disabledElementsLookup even if we never use the value.

What is the new behavior (if this is a feature change)?
In $animate.enabled(), we look up in disabledElementsLookup only if we need the value.

Does this PR introduce a breaking change?
No.

Please check if the PR fulfills these requirements

Other information:
No 😕

@petebacondarwin
Copy link
Contributor

LGTM

@gkalpak gkalpak closed this in 489224b Jul 12, 2016
gkalpak added a commit that referenced this pull request Jul 12, 2016
@gkalpak gkalpak deleted the refactor-animate-avoid-unnecessary-lookup branch July 12, 2016 19:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants