This repository was archived by the owner on Apr 12, 2024. It is now read-only.
fix(ngOptions): don't duplicate groups with falsy values #14784
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Narretz
force-pushed
the
fix-ngoptions-duplicate-groups
branch
from
91160c8 to
20ffdef
Compare
| @@ -661,7 +661,7 @@ var ngOptionsDirective = ['$compile', '$document', '$parse', function($compile, | |||
| listFragment.appendChild(groupElement); | |||
|
|
|||
| // Update the label on the group element | |||
| groupElement.label = option.group; | |||
| groupElement.label = option.group === null ? 'null' : option.group; | |||
There was a problem hiding this comment.
Is this needed for some specific browser? In Chrome that I tried, null seems to be converted to "null" anyway.
There was a problem hiding this comment.
Who else? Safari is officially the new IE 😛
|
LGTM |
This happened when the options were updated, because ngOptions would fail to remove optgroups with falsy values Related angular#14781
Narretz
force-pushed
the
fix-ngoptions-duplicate-groups
branch
from
e86934f to
cf93847
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
bugfix
What is the current behavior? (You can also link to an open issue here)
see #14781
Please check if the PR fulfills these requirements
[ ]Docs have been added / updated (for bug fixes / features)This happened when the options were updated, because ngOptions would fail
to remove optgroups with falsy values
Related #14781