This repository was archived by the owner on Apr 12, 2024. It is now read-only.
chore(version-info.js): ignore curl file write errors #14780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (cdnResult.code === 0) { | ||
| // Ignore if Curl can't write the file (code 23), e.g. on Windows, as we still get | ||
| // the needed output from --write-out | ||
| if (cdnResult.code === 0 || cdnResult.code === 23) { | ||
| var statusCode = cdnResult.output.trim(); |
There was a problem hiding this comment.
Really we only care about whether requests to this URL are 404 or not, right?
Why don't we ditch the curl altogether and just use the http library?
https://nodejs.org/dist/latest-v4.x/docs/api/http.html#http_http_request_options_callback
Narretz
added a commit
that referenced
this pull request
Jun 16, 2016
Since we cannot write to dev/null on Windows, don't write to a file at all, but simply use stdout and extract the output from --write-out from the process response. Credit to @petebacondarwin for the idea. The commit also avoids a premature error when no cdnVersion could be found online, and improves the log wrt the origin of the versions. PR (#14780)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Windows, curl can obviously not write to
dev/null, and throws code 23, which prevents us from checking that the CDN server responded. However, we don't need the file anyway, we just need the status code, so we can ignore the file write error.This needs to be tested on Linux / Mac however!