This repository was archived by the owner on Apr 12, 2024. It is now read-only.
Docs ngmessageformat examples #14770
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Narretz
commented
Jun 14, 2016
Narretz
commented
- add examples for gender and gender + plural to the ngMessageFormat docs
- move the docs to the ngMessageFormat module namespace, as $$messageFormat is a private service
Narretz
force-pushed
the
docs-ngmessageformat-examples
branch
from
e245028 to
c8ee2d8
Compare
Narretz
added a commit
to Narretz/dgeni-packages
that referenced
this pull request
Jun 14, 2016
This happens in rare cases, for example ngMessageFormat has no special api surface, as it integrates with the $interpolate service. See angular/angular.js#14770
…ace. This is a private service that should not be documented. The docs have been moved to the ngMessageFormat module namespace.
Some modules (ngMessageFormat, ngParseExt) don't have their own api surface because they integrate with core services ($interpolate and $parse respectively).
Narretz
force-pushed
the
docs-ngmessageformat-examples
branch
from
c8ee2d8 to
94316e5
Compare
petebacondarwin
pushed a commit
that referenced
this pull request
Jun 14, 2016
…ace. This is a private service that should not be documented. The docs have been moved to the ngMessageFormat module namespace. Closes #14770
petebacondarwin
pushed a commit
that referenced
this pull request
Jun 14, 2016
Some modules (ngMessageFormat, ngParseExt) don't have their own api surface because they integrate with core services ($interpolate and $parse respectively). Closes #14770
|
Did you fix the build errors? |
|
It build fine locally.... oops |
|
Is it the e2e tests? |
|
One was in style checks but that was probably fixed by building locally.
The others were docs. We'll see
|
|
I have pushed the ci-check fix |
|
I will fix up the e2e tests now - sorry |
petebacondarwin
pushed a commit
that referenced
this pull request
Jun 14, 2016
petebacondarwin
pushed a commit
that referenced
this pull request
Jun 14, 2016
…ace. This is a private service that should not be documented. The docs have been moved to the ngMessageFormat module namespace. Closes #14770
petebacondarwin
pushed a commit
that referenced
this pull request
Jun 14, 2016
Some modules (ngMessageFormat, ngParseExt) don't have their own api surface because they integrate with core services ($interpolate and $parse respectively). Closes #14770
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.